dev/financial#152 [REF] Parse ids before sending to single function (minor simplification) #18631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview ---------------------------------------- Minor simplification - parse ids into valid format & pass them into single, rather than passing them in wrong & 'asking' single to parse them Before ---------------------------------------- parsing of ids into usable array done at the last minute, other values passes around unnecessarily After ---------------------------------------- parsing done close to the point where they are derived Technical Details ---------------------------------------- Comments ----------------------------------------
|
(Standard links)
|
eileenmcnaughton
changed the title
|
Ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor simplification - parse ids into valid format & pass them into single, rather than passing them in wrong & 'asking' single to parse them
Before
parsing of ids into usable array done at the last minute, other values passes around unnecessarily
After
parsing done close to the point where they are derived
Technical Details
Comments