Fix bug in primary handling where TRUE rather than 1 used #18598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug where ensuring valid primary addresses relies on is_primary being 1 or 0 but NOT TRUE of FALSE
Before
Updating a phone (etc) results in other phones for the contact being updated to is_primary = 0
but this does not
After
Both variants trigger is_primary cycle.
Technical Details
When a phone (etc) is updated to have is_primary = 1 then all the other phones for that contact should be is-primary = 0
Comments
@colemanw Note apiv4 still bypasses primary handling, for address at least