dev/core#2046 Fix Phone:add to be a pseudonym for Phone.create

[eileenmcnaughton]

Overview

Per https://lab.civicrm.org/dev/core/-/issues/2046 we have discussed rationalising add vs create

In the case of phone making this change only affects one place - a place that currently has a
bug that relates specifically to the handling of is_primary & which is more solvable by
calling create with it's extra is_primary handling.

Before

Phone::create calls Phone::add, duplicating CRM_Core_DAO::checkSqlFunctionsExist();
Phone::add does not handle 'is_primary'

After

CRM_Core_DAO::checkSqlFunctionsExist(); only called once - see https://lab.civicrm.org/dev/core/-/issues/27 for further proposal. is_primary handled in add which calls create & is deprecated

Technical Details

Comments

The related bug is that the is_primary handling in Block::create is unreliable &
to mitigate that we are doing an additional 10 queries on every contact create - so
handling is_primary right in the first place helps address that - see https://lab.civicrm.org/dev/core/-/issues/2039

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I think unit tests will pick up on any problems with this due to the deprecation notice being triggered.