Add select2-bootstrap to greenwich theme

[colemanw]

Overview

Adds bootstrap-3 styling to select2 elements.

Before

After

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

nice!

[colemanw]

@totten unfortunately the composer-compile step crashes. Only workaround I've found so far is to manually rename the file bower_components/select2/select2-bootstrap.css and give it an .scss extension.

[seamuslee001]

@colemanw why is this needed is there an issue with the import if its not there?

[seamuslee001]

@colemanw does it make more sense to include something like https://github.com/civicrm/civicrm-core/blob/master/ext/greenwich/greenwich.php#L55 ?

[colemanw]

@colemanw does it make more sense to include something like https://github.com/civicrm/civicrm-core/blob/master/ext/greenwich/greenwich.php#L55 ?

Then I think it wouldn't get the #bootstrap-theme namespace prefixing.

[totten]

unfortunately the composer-compile step crashes. Only workaround I've found so far is to manually rename the file bower_components/select2/select2-bootstrap.css and give it an .scss extension.

I didn't realize that select2-bootstrap.css was bundled with select2.

OK, so for completeness, the error that appears to me is:

Fatal error: Uncaught ScssPhp\ScssPhp\Exception\ParserException:
Error : `border-radius: 0 2px 2px 0;` isn't allowed in plain CSS (assign): failed at `}`
../../bower_components/select2/select2-bootstrap.css on line 9, at column 1
in /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/vendor/scssphp/scssphp/src/Parser.php:150

Which seems to indicate that (1) ScssPhp does allow importing *.css files but (2) it treats them differently than importing *.scss. This particular error doesn't mean much to me, but it's understandable that different file-extensions would have different import-semantics.

How's this as a fairly straight interpretation of your local work-around:

totten@89bef74

[colemanw]

Yes that's the error message I got too. I tried deleting the "offending" line in the css file and then got the same error for many more lines in the file. To me it looks like a bug in the php scss compiler, but whatever, this workaround works for now.

[totten]

OK, cool.

@colemanw I have a slightly better form of the same patch now - it's a bit more intuitive to manage the 'watch' list, and I expect it to run better on Windows. It needs an update version of compile-plugin v0.8. Changes pushed onto the PR.

[colemanw]

@totten I tested it and it works well.