Simplify CRM_Core_BAO_Location::createLocBlock by moving eventLocation specific handling back to the class #18578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
api42
branch
2 times, most recently
from
3c5bc3f to
247db7c
Compare
…n specific handling back to the class On grepping universe we find entity is only passed into CRM_Core_BAO_Location::createLocBlock from this one place in the code - ergo we can do the handling for it on that class & not in the shared code Test cover added in preparation for this to CRM_Event_Form_ManageEvent_LocationTest
eileenmcnaughton
force-pushed
the
api42
branch
from
247db7c to
531b6c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Simplify CRM_Core_BAO_Location::createLocBlock by moving eventLocation specific handling back to the class - note how the 3rd parameter is only non-null in one place...
Before
Handling in CRM_Core_BAO_Location::createLocBloc that pertains only to CRM_Event_Form_ManageEvent_Location
After
Handling moved to CRM_Event_Form_ManageEvent_Location
Technical Details
On grepping universe we find entity is only passed into
CRM_Core_BAO_Location::createLocBlock from this one place in the code - ergo we can
do the handling for it on that class & not in the shared code
Incorporates #18577
Comments
Test cover added in preparation for this to CRM_Event_Form_ManageEvent_LocationTest so adding has-test