Switch to non-deprecated/cached functions for membership pricesets

[mattwire]

Overview

CRM_Member_BAO_MembershipType::getMembershipTypeDetails() and CRM_Member_BAO_MembershipType::getMembershipTypeOrganization() functions are non-cached functions to get information about the membershipType.

Switch to CRM_Member_BAO_MembershipType::getMembershipType() which is a cached function to get information about the same thing.

Partial from #18398 which is attempting to rationalise and cleanup the use of multiple functions to get the same information.

Before

Using non-cached function to get membershipType detail.

After

Using "standard" cached function to get membershipType detail.

Technical Details

Pricesets are often built multiple times as forms load or are submitted. By using cached functions we reduce the number of database lookups to one when we need to get information about membershiptypes.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

The code looks correct. I checked & there was no cover on these lines & I couldn't justify merging without unless it was reaaallly hard to do - but it turned out not to be #18580

[seamuslee001]

Jenkins re test this please

[seamuslee001]

@eileenmcnaughton if this test run passes are you good with this PR then?

[eileenmcnaughton]

yep