Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the post-upgrade thank you message to include URLs to CiviCRM contributors, CiviCRM members and minor rewrite #18559

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

agileware-justin
Copy link
Contributor

Update the post-upgrade thank you message to include URLs to CiviCRM contributors, CiviCRM members and minor rewrite

Overview

Update the post-upgrade thank you message to include URLs to CiviCRM contributors, CiviCRM members and minor rewrite

Before

URLs to CiviCRM contributors, CiviCRM members were not included. Text needed some improvement.

After

URLs to CiviCRM contributors, CiviCRM members now included. Text re-written.

Comments

I think it fair that URLs to the actual CiviCRM contributors, CiviCRM members should be included. Have added distinct calls to action for joining as a member or partner.
Removed the text for "upgraded to latest CiviCRM" as it's not always the case that this version is the latest.
Have explained why financially supporting CiviCRM is important.

Agileware Ref: CIVICRM-1567

@civibot
Copy link

civibot bot commented Sep 22, 2020

(Standard links)

@civibot civibot bot added the master label Sep 22, 2020
@eileenmcnaughton
Copy link
Contributor

@joshgowans

@eileenmcnaughton
Copy link
Contributor

test this please

@joshgowans
Copy link
Contributor

I think this is mostly a good suggestion, however a few of the links are not quite right. The revision has: https://civicrm.org/providers/contributors as the new link, however that routes to the partner listing.

A new contributor list is in development and should be located at https://civicrm.org/contributors when it is live. The current partner listing is at https://civicrm.org/partners-contributors however this URL should change to https://civicrm.org/partners

Once these lists come online, then I believe it would be cool to merge this (with the URL updates).

…s to CiviCRM contributors, CiviCRM members and minor rewrite
@agileware-justin
Copy link
Contributor Author

@joshgowans links updated

@eileenmcnaughton
Copy link
Contributor

@joshgowans ok to merge now? It won't be released for another 6 weeks so there is time for any fixes to make the links work

@agileware-justin
Copy link
Contributor Author

"Test failure is unrelated"

@eileenmcnaughton
Copy link
Contributor

may as well get the green tick & then when @joshgowans confirms it can be merged without someone having to check

@eileenmcnaughton
Copy link
Contributor

test this please

@joshgowans
Copy link
Contributor

Thank @agileware-justin looks good. Sorry for delay.

@seamuslee001
Copy link
Contributor

Merging as per review by @joshgowans

@seamuslee001 seamuslee001 merged commit 5653540 into civicrm:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants