Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Cleanup in test class #18539

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 21, 2020

Overview

Minor cleanup to test class (single quotes, Camel case entities for calling ipn, use getsingle)

Before

e.g

$contribution = $this->callAPISuccess('contribution', 'get', ['id' => $this->_contributionID, 'sequential' => 1]);

After

e.g

$contribution = $this->callAPISuccessGetSingle('Contribution', ['id' => $this->_contributionID]);

Technical Details

This didn't catch everything - just some of them

Comments

Minor cleanup to test class (single quotes, Camel case entities for calling ipn, use getsingle)
@civibot
Copy link

civibot bot commented Sep 21, 2020

(Standard links)

@civibot civibot bot added the master label Sep 21, 2020
@pradpnayak
Copy link
Contributor

Good to merge

@eileenmcnaughton
Copy link
Contributor Author

urelated fail

@eileenmcnaughton eileenmcnaughton merged commit 4eb35a8 into civicrm:master Sep 21, 2020
@eileenmcnaughton eileenmcnaughton deleted the ppcancel branch September 21, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants