[REF] Paypal std ipn Move not-actually shared-code out of shared code function

[eileenmcnaughton]

Overview

[REF] Move not-actually shared-code out of shared code function

Before

single function appears to hold a lot of code that is shared between the main function and the recur function but on looking at the recur function it turns out to be entirely unreachable from there.

After

non-shared code returned to the function that uses it.

Technical Details

On looking at the recur function it turns out it never calls without a
paymentStatus of 'Completed' ie it only proceeds to call single if $txnType == 'subscr_payment'

civicrm-core/CRM/Core/Payment/PayPalIPN.php

Line 180 in 26ec07d

if ($txnType != 'subscr_payment') {

And if ``$txnType == 'subscr_payment'``` then paymentStatus must be Completed

civicrm-core/CRM/Core/Payment/PayPalIPN.php

Line 79 in 26ec07d

if ($input['txnType'] === 'subscr_payment' &&

• so the lines handling other payment statuses are not actually shared
  between the 2 code paths but specifically belong to the 'main' (non-recur) code path.

Moving it out of this function we start to see there is very little shared code & probably no case for
the function to exist when we get down to it

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please