Skip to content

[REF] Fix visibility of afform_scanner container service for Symfony … #18505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

[REF] Fix visibility of afform_scanner container service for Symfony … #18505

merged 1 commit into from
Sep 18, 2020

Conversation

seamuslee001
Copy link
Contributor

…3 and 4

Overview

This is the same fix as many other recent fixes as per #18443

Before

Symfony service is private in 3 & 4

After

Symfony service is public in 3 & 4

@civibot
Copy link

civibot bot commented Sep 17, 2020

(Standard links)

@civibot civibot bot added the master label Sep 17, 2020
@totten
Copy link
Member

totten commented Sep 18, 2020

Looks sensible. This line gets a lot of implicit coverage by way of afform's test-suite. MOP.

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit e68535e into civicrm:master Sep 18, 2020
@eileenmcnaughton eileenmcnaughton deleted the afform_container_fix branch September 18, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @totten @eileenmcnaughton