Remove long-deprecated hook_civicrm_tabs

[colemanw]

Overview

This hook has been deprecated for 5 years. Time to remove it.

Before

Long-deprecated hook exists.

After

So long, farewell...

Comments

I searched through CiviCRM Universe and found that most extensions have already made the transition. Some older, less-maintained extensions have not. I submitted PRs to update them, in case they are still being maintained...

• Update hook_civicrm_tabs -> hook_civicrm_tabset sgladstone/com.fountaintribe.financialsummaries#4
• Update hook_civicrm_tabs -> hook_civicrm_tabset systopia/de.systopia.donrec#112
• https://lab.civicrm.org/extensions/multisite/-/merge_requests/1
• Update hook_civicrm_tabs -> hook_civicrm_tabset CiviCooP/no.maf.oppgavexml#1
• Update hook_civicrm_tabs -> hook_civicrm_tabset CiviCooP/org.civicoop.contactsegment#12
• Update hook_civicrm_tabs -> hook_civicrm_tabset compucorp/civibooking#192
• Update hook_civicrm_tabs -> hook_civicrm_tabset futurefirst/uk.org.futurefirst.networks.civipoints#19
• Update extension + deprecated hook cividesk/com.cividesk.apikey#2

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I think you've done the research pretty solidly - in other places we've added deprecation notices where a hook changes stuff to trigger people to alter - which might have saved you having done a couple of those PRs - but this seems sane & it's long-deprecated.

Docs PR civicrm/civicrm-dev-docs#855
https://github.com/civicrm/civicrm-dev-docs/pull/856/files

[colemanw]

@eileenmcnaughton AFAIK it's not possible to add a deprecation notice to a hook because of the way it's dispatched through the CMS and Symfony.