dev/core#2047 [REF] Minor code extraction #18499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
merger
branch
2 times, most recently
from
743039e to
53d07eb
Compare
This extracts code to the MergeHandler class for deduping locations. We have a LOT of test cover here with all the scenarios in jobTest::testBatchMergesAddresses & other functions using that same data provider. The goal is to refactor the code onto the MergeHandler class, with a view to doing less variable passing & more property-using to help clean it up - in this case it's already visible that 2 variables can be derived in the mergeHandler:
eileenmcnaughton
force-pushed
the
merger
branch
from
53d07eb to
1e809f0
Compare
eileenmcnaughton
changed the title
|
@pfigel @JKingsnorth can either of you check this |
|
Looks good to me... |
|
@seamuslee001 @colemanw also some review by @pradpnayak on this one (thanks @pradpnayak ) |
|
Merging as per @pradpnayak review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code extraction in (heavily tested) moveLocations action
Before
Long chunk of code
After
Partially extracted to the MergeHandler class
Technical Details
This extracts code to the MergeHandler class for deduping locations. We have a LOT of
test cover here with all the scenarios in jobTest::testBatchMergesAddresses & other functions
using that same data provider.
The goal is to refactor the code onto the MergeHandler class, with a view to
doing less variable passing & more property-using to help clean it up -
in this case it's already visible that 2 variables can be derived in the mergeHandler:
Comments