dev/core#2046 Rationalise add vs create on email BAO

[eileenmcnaughton]

Overview

This folds the email::add function into the email:create functions into one, deprecating add

• note test fail expected until dev/core#2039 [NFC] Test cleanup to stop calling Email::add action  #18494 is merged

Before

create calls add, add not deprecated

After

add deprecated wrapper for create

Technical Details

Discussion would be better over https://lab.civicrm.org/dev/core/-/issues/2046

Comments

Per comments on gitlab- I will close this & continue the discussion in gitlab unless this seems straight forward - once
#18494 is merged I do not believe ::add is called except from create - except for here https://github.com/giant-rabbit/com.giantrabbit.civimailchimp/blob/9fed1abd9680b1ae0e352c97b6370a6378d0313d/CRM/CiviMailchimp/Page/Webhook.php#L88 - I added an issue there on it giant-rabbit/com.giantrabbit.civimailchimp#4

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please