dev/financial#148 Simplify parameters passed to completeOrder

[eileenmcnaughton]

Overview

Simplifies the code in Event batch update to no longer interact with the BaseIPN class - specifically when updating an event to Completed

Before

$baseIPN validate called to retrieve 'objects' - but in practice doing the same as contribution->fetch() plus an incorrect guess at the relevant payment processor

After

just calls contribution->fetch()

Technical Details

Now that completeOrder has had most interaction with objects var cleaned up
we know only 2 objects are actually used

• contribution - which we can fetch in-function
• paymentProcessor - which we were actually only guessing

This alters it to only load & pass contribution. The value of passing in
processor seems lost in time. This code can only be reached for pay_later contributions - see

CRM_Contribute_BAO_Contribution::checkOnlinePendingContribution
and specifically

civicrm-core/CRM/Contribute/BAO/Contribution.php

Line 2033 in 318c630

$dao->is_pay_later &&

and only when submitted via an online event (same function) so by definition there IS NO PAYMENT PROCESSOR that applies.

Given that we can just do the minimum to load the contribution and pass that in.

Testing notes

I added CRM_Event_Form_Task_BatchTest::testSubmit prior to starting cleanup on this code. It passes through the altered lines & should lock in 'no change of behaviour'

Comments

Original PR was closed by accident (by me) #18390

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@JoeMurray @monishdeb this is the last one - looks like I deleted the branch by accident - looking for the original PR now. This is a bit more tangential. It has good test cover but needs an r-run