dev/core#2017 Move function only used by bin/ContributionProcessor to that class

[eileenmcnaughton]

Overview

We should find a way to move this out of core - it seems likely it's never used but since being moved out
of svn it's had about 40 commits - all of which are just 'general maintenance' - licensing, coding standards etc.

There is an overhead in maintaining it....

Before

Function is only used by bin/ContributionProcessor but is not on that class

After

Function is only used by bin/ContributionProcessor and is on that class

Technical Details

I haven't looked at tests here because of my strong feeling this code is unused and we should be working to get rid of it rather than improve support. This is a small step in that direction

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 this should be an easy merge....

[pradpnayak]

Yes, its good to merge as _fillCommonParams() is only used in bin/ContributionProcessor.php

[mattwire]

Merging based on @pradpnayak review