Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] minor tidy up on membershipStatus::create & add #18435

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

We have been deprecating & removing the array from BAO create & add actions - this continues that
(long slow) process'

Before

MembershipStatus::add already prefers not to receive ids - but create still conjures them up

After

ids no longer passed to add

Technical Details

I managed to eliminate most of the places add is called - I think ideally add would just be a (deprecated) pseudonym for create

Comments

We have been deprecating & removing the  array from BAO create & add actions - this continues that
(long slow) process'
@civibot
Copy link

civibot bot commented Sep 11, 2020

(Standard links)

@civibot civibot bot added the master label Sep 11, 2020
@colemanw
Copy link
Member

Cleanup makes sense & tests pass.

@colemanw colemanw merged commit aa7fe34 into civicrm:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants