Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2017 Remove unused function OpenID::isAllowedToLogin #18430

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 11, 2020

Overview

Remove unused function OpenID::isAllowedToLogin

Before

Screen Shot 2020-09-11 at 8 00 13 PM

After

poof

Technical Details

Comments
https://lab.civicrm.org/dev/core/-/issues/2017

@civibot
Copy link

civibot bot commented Sep 11, 2020

(Standard links)

@civibot civibot bot added the master label Sep 11, 2020
@pradpnayak
Copy link
Contributor

Looks good to me, have asked @davejenx if this function is used in any of our custom module or extension

@eileenmcnaughton
Copy link
Contributor Author

Thanks @pradpnayak - maybe @davejenx can recall last time he saw anything to do with open id in use....

@eileenmcnaughton
Copy link
Contributor Author

@nganivet you don't use this do you?

@colemanw
Copy link
Member

I can't find any references to it in CiviCRM Universe

@eileenmcnaughton
Copy link
Contributor Author

@colemanw neither - I don't think we need to wait for @nganivet to reply - I just wanted to get the ping in there

@colemanw colemanw merged commit 5df3f10 into civicrm:master Sep 22, 2020
@colemanw colemanw deleted the open branch September 22, 2020 22:23
@nganivet
Copy link
Contributor

@eileenmcnaughton thanks for the ping, we are not using this function or anything related to openid anymore, so +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants