Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2009 filter grant dashboard to exclude trashed contacts #18428

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

lcdservices
Copy link
Contributor

Overview

The grant dashboard tallies include contacts that are trashed and shouldn't. To reproduce:

observe current dashboard stats for a specific status
create a contact and create a grant with that same status
trash the contact
observe the dashboard stats. it will have incremented by 1, including the trashed record

If you click the hyperlink to search for grants the trashed record is properly excluded. It's just the dashboard stats that are off.

Before

Grant dashboard counts grants attached to trashed contacts.

After

Grant dashboard does not count grants attached to trashed contacts.

@civibot
Copy link

civibot bot commented Sep 10, 2020

(Standard links)

@civibot civibot bot added the master label Sep 10, 2020
@JoeMurray
Copy link
Contributor

I approve this. Merge on pass.

@eileenmcnaughton eileenmcnaughton merged commit 63bdd8b into civicrm:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants