dev/core#2009 filter grant dashboard to exclude trashed contacts #18428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The grant dashboard tallies include contacts that are trashed and shouldn't. To reproduce:
observe current dashboard stats for a specific status
create a contact and create a grant with that same status
trash the contact
observe the dashboard stats. it will have incremented by 1, including the trashed record
If you click the hyperlink to search for grants the trashed record is properly excluded. It's just the dashboard stats that are off.
Before
Grant dashboard counts grants attached to trashed contacts.
After
Grant dashboard does not count grants attached to trashed contacts.