NFC Clarify what CRM_Price_BAO_Priceset::getMembershipCount does

[mattwire]

Overview

Partial from #18398

This updates the docblock and variable name to clarify what the CRM_Price_BAO_Priceset::getMembershipCount() function actually does. It is called from a few places in the membership/contribution code and could probably be replaced. But first step is to make it clear what it actually does.

For example, reading the code you might easily make the assumption that the param $ids is an array of IDs.. But it's not.. It's actually a comma separated string of IDs.

Before

Difficult to understand what function is doing and expected params.

After

Easier to understand what function is doing and expected params.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).