Fix formatLocaleNumericRoundedByCurrency

[eileenmcnaughton]

Overview

The function was rounding by a max of 2 regardless of the number of places passed - it
was only tested for 2 so seemed to work

Before

Regardless of the value of $numberOfPlaces it is always rounded to 2

 protected static function formatLocaleNumericRounded($amount, $numberOfPlaces) {

After

Rounds to actual number of places

Technical Details

This is the function fix pulled out of #18297

In ^^ there was an example which didn't work - the issue is at the php layer - the value is truncated by php & we won't resolve that without implementing brickmoney but it seems reasonable to leave out of scope

See how hard coded amount is passed directly to a function

But it's received differently in the functionn

The total string length seems to matter - one less character at the beginning is one less at the end

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks fine to me merge on pass