[REF] simplify interaction with objects in complete order #18385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per civicrm#18382 this line seems to be heavily tested so & per the test we can use the 'already calculated value' for payment_processor_id rather than look it up in yet another place. This adds a query but in most cases queries can be removed before calling this function as the various objects are not really accessed anymore (apart from the few lines just above this)
|
(Standard links)
|
|
@mattwire looks like we missed a trick on this one - fortunately @demeritcowboy picked it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code simplification
Before
$paymentProcessorID needs to be in $objects AND $contribution->_relatedObjects
After
Only objects accessed
Technical Details
Per #18382 this line seems to be heavily tested so
& per the test we can use the 'already calculated value' for payment_processor_id rather than look
it up in yet another place.
This adds a query but in most cases queries can be removed before calling this function as
the various objects are not really accessed anymore (apart from the few lines just above this)
Comments
@seamuslee001