Finish deprecating BaseIPN->completeTransaction #18381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been marked deprecated, but still called for a long timme. Now that it is just a one-liner I think it's cleaner if the core processors that use it do the one line directly
|
(Standard links)
|
|
Ok, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Noisily deprecate BaseIPN->completeTransaction
Before
Function marked deprecated but still called from 3 places, even though it's now just a one liner
After
Function by-passed & deprecated
Technical Details
This has been marked deprecated, but still called for a long timme.
Now that it is just a one-liner I think it's cleaner if the core processors that use it do the one line
directly
Comments
@seamuslee001 should be straight-forward