Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report#45 Switch out function call CRM_Utils_Array::value and extend … #18379

Merged
merged 1 commit into from
Sep 5, 2020
Merged

report#45 Switch out function call CRM_Utils_Array::value and extend … #18379

merged 1 commit into from
Sep 5, 2020

Conversation

seamuslee001
Copy link
Contributor

…test coverage

Overview

Followup to #18246 as per @MegaphoneJon 's comments #18246 (comment)

Before

Test coverage only covered searching smart groups as the filter type

After

Test coverage covers all 3 states

ping @MegaphoneJon @eileenmcnaughton

@civibot
Copy link

civibot bot commented Sep 5, 2020

(Standard links)

@civibot civibot bot added the master label Sep 5, 2020
@eileenmcnaughton eileenmcnaughton merged commit 98507fe into civicrm:master Sep 5, 2020
@eileenmcnaughton eileenmcnaughton deleted the report_45 branch September 5, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton