Fixed pre hook params for LineItem #18340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
pradpnayak
force-pushed
the
lineItemFix
branch
from
ad1a854 to
147699a
Compare
eileenmcnaughton
added
the
merge ready
|
Thanks @pradpnayak - I've added merge-ready to give @monishdeb a bit longer to check in case it's used somewhere in the line item editor. Also @KarinG maybe I don't think a test is needed on this one since we don't specifically test hook params on other pre hooks |
|
@eileenmcnaughton can you rebase |
|
It's not my PR - @pradpnayak |
|
@pradpnayak this will need a rebase I checked this out locally and then ran the lineitemeditors unit tests and they all passed so I think this is fine |
|
test this please |
|
I kicked off the tests so I can swap merge-ready to merge-on-pass which is more accurately the intent |
eileenmcnaughton
added
merge on pass
and removed
merge ready
pradpnayak
force-pushed
the
lineItemFix
branch
from
147699a to
50cc8e4
Compare
pradpnayak
force-pushed
the
lineItemFix
branch
from
50cc8e4 to
1e6dcc0
Compare
|
Test fail unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/1994