dev/core#1974: correct UI regression on custom field edit #18304
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Corrects the UI issue on the Custom Field edit form mentioned in https://lab.civicrm.org/dev/core/-/issues/1974
Before
When editing an existing Multi-Select field, the form showed the type as "Select" in a frozen element and, lower down on the form, offered a "Multi-Select" checkbox which could be unchecked, but doing so had no effect. The user might think they had changed the field from multi-select to select, but the change was not saved.
After
The form shows the type as "Select (Multi-Select)" in a static element. The user can still change the field type by using the "Change Input Field Type" link.
That's in Edit mode. In Create mode, the "Multi-Select" checkbox makes sense, so we keep it appearing (and working) as before.
Notes
"Select (Multi-Select)" is a bit awkward. I'd prefer just "Multi-Select" but this solution keeps the code changes to a minimum.