Remove ajax timeout from contribution page on behalf of

[mattwire]

Overview

You'll probably only hit this timeout when debugging / slow connection. But it's the only place (I could find) that specifies an AJAX timeout in CiviCRM templates/js and it doesn't seem needed.

Before

AJAX call civicrm/ajax/permlocation times out after 5 seconds and you see "Common.js HTTP timeout" in browser console if debugging / site is slow to load / changing payment processors is slow.

After

Timeout gone. civicrm/ajax/permlocation loads in it's own time without timeout. If there was a real problem you'd see a 500 error or similar.

Technical Details

It is possible to specify timeouts on AJAX calls but we generally don't in CiviCRM.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw

[agileware-justin]

Pretty sure we need to have a timeout otherwise the browser will just hang there, waiting for a response - even if that response never arrives.

[mattwire]

@algileware-justin the issue is this is the only ajax call in CiviCRM where a timeout is defined. If it doesn't return it's quite likely that the rest of the page won't work either as it suggests a network issue or similar. There is also no handling on the form for the case when the request times out.

[agileware-justin]

@mattwire that sounds great :)

[eileenmcnaughton]

ok-without-test as not really testable