Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure serialize field exists before adding to query #17876

Merged

Conversation

colemanw
Copy link
Member

Overview

Backport of #17875 to solve upgrade woes.

Before

Upgrade crashes for sites with civicrm_views enabled & possibly other situations.

After

Problem reported to be solved by this patch.

Technical Details

This is a more minimal patch than #17875 - just enough to get the job done for 5.27.

@civibot
Copy link

civibot bot commented Jul 17, 2020

(Standard links)

@civibot civibot bot added the 5.27 label Jul 17, 2020
@seamuslee001
Copy link
Contributor

@colemanw is there a 5.28 version?

@seamuslee001
Copy link
Contributor

found the answer to my own question it is here #17875

@eileenmcnaughton
Copy link
Contributor

I recognise the case fail but not those website fails?

@colemanw
Copy link
Member Author

retest this please

@eileenmcnaughton
Copy link
Contributor

est Result (7 failures / +7)
CRM_Activity_Form_SearchTest.testQill with data set #0
CRM_Case_BAO_CaseTest.testSortByCaseContact
api_v3_TaxContributionPageTest.testCreateContributionOnline with data set #0
api_v3_WebsiteTest.testDeleteWebsite with data set #0
api_v3_WebsiteTest.testDeleteWebsite with data set #1
api_v3_WebsiteTest.testDeleteWebsiteInvalid with data set #0
api_v3_WebsiteTest.testDeleteWebsiteInvalid with data set #1

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

Test fails unrelated now

@eileenmcnaughton
Copy link
Contributor

Test Result (2 failures / +2)
E2E.Core.PrevNextTest.testDeleteByCacheKey
CRM_Case_BAO_CaseTest.testSortByCaseContact

@eileenmcnaughton eileenmcnaughton merged commit b87b3cf into civicrm:5.27 Jul 20, 2020
@eileenmcnaughton eileenmcnaughton deleted the customFieldVersionCheck-5.27 branch July 20, 2020 02:31
@eileenmcnaughton
Copy link
Contributor

@totten @colemanw @seamuslee001 should we drop a new point version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants