Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1882 - Missing version number in status check message about db version vs code version #17854

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Jul 15, 2020

Overview

https://lab.civicrm.org/dev/core/-/issues/1882

It says ...The v codebase may not be compatible with your database state...

Before

version missing

After

version shown

Technical Details

In https://github.com/civicrm/civicrm-core/pull/17722/files#diff-50f6e167c4bfdcf605b5e0617d06b82d some of the code got moved around and the variable that holds the version got moved with it.

Comments

It affects 5.27 too.

@civibot
Copy link

civibot bot commented Jul 15, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

:+1 Merge on pass

@seamuslee001
Copy link
Contributor

Test fails unrelated

@seamuslee001 seamuslee001 merged commit 0782187 into civicrm:5.28 Jul 16, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the missing-codeversion-5.28 branch July 16, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants