core#1840 - Can't add/change recipient on non-bulk SMS

[MegaphoneJon]

https://lab.civicrm.org/dev/core/-/issues/1840

Overview

When sending a non-bulk SMS, you can't add recipients or change the recipient; only the default recipient works.

Before

Crash with an exception:

CRM_Core_Exception: One of parameters  (value: "Lastname) is not of the type Positive

After

Works.

Technical Details

The JS is making an AJAX request to CRM_Contact_Page_AJAX::getContactPhone(). In line 451, you can see that the results can be returned in one of two formats, depending on whether it was called with a true id parameter. This JS wasn't passing id, so it was getting back the results in an incorrect format.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
    • Can confirm the problem and patch fixes it.
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
  • [r-maint] Undecided
  • [r-test] PASS
    • Test fail is a known flaky test but just in case: jenkins test this please.

I'm surprised I haven't heard about this from users out in the field, but I tested with a real account with a real provider and it's a thing.