dev/core#1833 Change default value of participant_listing_id to NULL …

[seamuslee001]

…from 0

Overview

This changes the default value of participant_listing_id column to be NULL rather than 0 as that makes more sense as 0 is not a real value

Before

Default value is 0

After

Default value is NULL

ping @eileenmcnaughton @colemanw

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@seamuslee001 This makes sense. Did you check if there is any wierd/wonderful code that is actually checking for 0?

[seamuslee001]

This seems to be the only relevant places that it is called from

CRM/Event/Page/EventInfo.php:    $participantListingID = $values['event']['participant_listing_id'] ?? NULL;
CRM/Event/Page/ParticipantListing/NameStatusAndDate.php:      'participant_listing_id'
CRM/Event/Page/ParticipantListing.php:      'participant_listing_id'
CRM/Event/Page/ParticipantListing.php:        'participant_listing_id',
CRM/Event/Form/ManageEvent.php:      $participantListingID = $eventInfo['participant_listing_id'] ?? NULL;
CRM/Event/Form/ManageEvent/EventInfo.php:    $this->addSelect('participant_listing_id', ['placeholder' => ts('Disabled'), 'option_url' => NULL]);
CRM/Admin/Page/EventTemplate.php:    $participantListings = CRM_Event_BAO_Event::buildOptions('participant_listing_id');
CRM/Admin/Page/EventTemplate.php:      if ($eventTemplate->participant_listing_id) {
CRM/Admin/Page/EventTemplate.php:        $allEventTemplates[$eventTemplate->id]['participant_listing'] = $participantListings[$eventTemplate->participant_listing_id];
templates/CRM/Event/Page/ManageEvent.tpl:                  {if $row.participant_listing_id}
templates/CRM/Event/Form/ManageEvent/EventInfo.tpl:    <tr class="crm-event-manage-eventinfo-form-block-participant_listing_id">
templates/CRM/Event/Form/ManageEvent/EventInfo.tpl:      <td class="label">{$form.participant_listing_id.label} {help id="id-listing" isTemplate=$isTemplate action=$action entityId=$entityId}</td>
templates/CRM/Event/Form/ManageEvent/EventInfo.tpl:      <td>{$form.participant_listing_id.html}</td>
tests/phpunit/CRM/Core/PseudoConstantTest.php:          'fieldName' => 'participant_listing_id',

[eileenmcnaughton]

I did a few checks & didn't spot anything worrying in those places