Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix Unit test failure on MySQL 8 due to mysql ordering issue #17674

Conversation

seamuslee001
Copy link
Contributor

Overview

This aims to fix a test failure that occurred on MySQL8 which is due to the ordering within the array by sorting the array first https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=master,label=test-3/lastCompletedBuild/testReport/(root)/CRM_Contact_BAO_ContactType_ContactTypeTest/testGetMethods/

Before

Test fails on MySQL8

After

Test passes on MySQL8

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jun 20, 2020

(Standard links)

@civibot civibot bot added the master label Jun 20, 2020
@seamuslee001
Copy link
Contributor Author

I did a manual run of this against the edge test with it patched in and the result was

ok 192 - CRM_Contact_BAO_ContactType_ContactTypeTest::testGetMethods

as per https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=master,label=test-3/537/consoleFull

@seamuslee001 seamuslee001 merged commit 5fbcc12 into civicrm:master Jun 21, 2020
@seamuslee001 seamuslee001 deleted the contacttype_test_mysql8_ordering_issue branch June 21, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants