Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Fix parts of code where curly brackets were being used for array or string access which is deprecated in PHP7.4 #17647

Merged
merged 1 commit into from
Jun 18, 2020
Merged

[REF] Fix parts of code where curly brackets were being used for array or string access which is deprecated in PHP7.4 #17647

merged 1 commit into from
Jun 18, 2020

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Jun 18, 2020 •
edited
Loading

Overview

PHP 7.4 deprecates using {} for array or string access

Before

Tests fail due to {} being used

After

Tests pass

Tests affected are

  • api_v3_ReportTemplateTest.testReportTemplateSelectWhere with data set CRM-11926 add a better error handling for db errors in the api #5 (from api_v3_ReportTemplateTest__testReportTemplateSelectWhere)
  • Civi\Angular\ChangeSetTest::testInsertAfter
  • Civi\Angular\ManagerTest::testGetPartials
  • Civi\Angular\PartialSyntaxTest::testConsistencyExamples

ping @mattwire @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jun 18, 2020

(Standard links)

@civibot civibot bot added the master label Jun 18, 2020
@seamuslee001
[REF] Patch electrolinux/phpquery and also core files to fix using {}…
a240692 
… when doing array or string access when it should be []
@seamuslee001 seamuslee001 changed the title WIP: Add in PHPQueryPatch [REF] Fix parts of code where curly brackets were being used for array or string access which is deprecated in PHP7.4 Jun 18, 2020
@seamuslee001 seamuslee001 merged commit 42e2be5 into civicrm:master Jun 18, 2020
@seamuslee001 seamuslee001 deleted the php74_query_fix_2 branch June 18, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton