Use PHPUnit7 as the primary test runner for PHP versions >= 7.1 when using the phpunit script #17615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
phpunit7_new
branch
6 times, most recently
from
ccb2893 to
4675ba7
Compare
seamuslee001
changed the title
seamuslee001
force-pushed
the
phpunit7_new
branch
2 times, most recently
from
770620c to
56eb704
Compare
|
@seamuslee001 why > - aren't we only testing php 7.1+ on master? |
seamuslee001
changed the title
|
@eileenmcnaughton just updated i meant >= PHP7.1 so this would capture all testing that is happening but if someone was still on PHP7.0 for some reason it would gracefully fallback to phpunit6 |
seamuslee001
force-pushed
the
phpunit7_new
branch
from
56eb704 to
259bf31
Compare
Fix tap printer
seamuslee001
force-pushed
the
phpunit7_new
branch
from
259bf31 to
8851bdf
Compare
|
If this works with our tests I think it's all good. We can easily respond if test issues emerge without impacting sites |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This updates our phpunit script to choose to use PHPUnit 7 as the primary PHPUnit runner when the PHP Unit version is 7.1 or greater. This is in part to help fix some Extension Manager tests on PHP7.4
Before
PHPUnit6 used as the primary runner
After
PHPUnit 7 used as the primary runner
At Present PHPUnit5 is still used as part of the Extension PR testing AFAIK and was being used until today (19.6.20) on the EXT-Matrix unit tests that has now been changed.
ping @mattwire @eileenmcnaughton @totten Note that this PR incorporates the changes in #17661