[REF] Replace incorrect usages of array_key_exists when the variable … #17573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
commented
Jun 10, 2020
CRM/Contact/BAO/Contact.php
Outdated
| @@ -175,7 +175,7 @@ public static function add(&$params) { | |||
| // Since hash was required, make sure we have a 0 value for it (CRM-1063). | |||
| // @todo - does this mean we can remove this block? | |||
| // Fixed in 1.5 by making hash optional, only do this in create mode, not update. | |||
| if ((!array_key_exists('hash', $contact) || !$contact->hash) && !$contact->id) { | |||
| if ((!property_exists($contact, 'hash') || !$contact->hash) && !$contact->id) { | |||
There was a problem hiding this comment.
The other option would be isset() but i feel like that might be taken care of by the other parts of the if
seamuslee001
force-pushed
the
incorrect_use_array_key_exists
branch
from
c7fe1e7 to
57ed021
Compare
…is not an array with property_exists and also fix the parameter order for an implode statement
seamuslee001
force-pushed
the
incorrect_use_array_key_exists
branch
from
57ed021 to
770d8a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is not an array with property_exists and also fix the parameter order for an implode statement
Overview
In PHP7.4 there has been a crackdown on where using array_key_exists is actually on an object not an array so I have swapped these out for property_exists and also fixed the paraemeter order on an implode which now if you don't pass the parameters in the correct order it puts out a deprecation notice
ping @eileenmcnaughton @colemanw