dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions… #17541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
… or status bounces as appropriate
seamuslee001
force-pushed
the
dev_core_560_third_to_last
branch
from
8a1e7dc to
7980012
Compare
|
I probably would have said the civix should have been a separate PR or at least commit - but OK it seems safe to let's be done with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… or status bounces as appropriate
Overview
This replaces the deprecated usage of CRM_Core_Error::fatal with either a statusBounce or an exception and re-generates the angularex extension civix file
Before
Deprecated function used
After
No Deprecated functions used
ping @eileenmcnaughton