[Ref] Mark unused date functions as deprecated

[eileenmcnaughton]

Overview

Flags unused functions for removal

Before

Not clear functions are on their way out

After

Functions are clearly deprecated

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mlutfy]

Seems fine by me, but will let someone else more qualified to merge :)

[eileenmcnaughton]

@mlutfy this is really a case of doing a grep & seeing if you agree they aren't used

[mlutfy]

I'm still seeing this:

$ grep -r returnDateRangeSelector
CRM/Core/Form/Date.php:      = CRM_Core_Form_Date::returnDateRangeSelector(
CRM/Core/Form/Date.php:  public static function returnDateRangeSelector(
bgm@erdenet:~/repositories/civicrm-core$ grep -r addDateRangeToForm
CRM/Core/Form/Date.php:    CRM_Core_Form_Date::addDateRangeToForm(
CRM/Core/Form/Date.php:  public static function addDateRangeToForm(

Other than that, I grepped in a set of extensions and they were not used there.

[eileenmcnaughton]

@mlutfy yep - aren't those calls from the deprecated functions?

[mlutfy]

Long day ;-)