CiviMail - Fix “Missing parameters” error in unsubscribe confirmation #17081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
session
branch
2 times, most recently
from
bb3bf85 to
b2ca42a
Compare
Possible fix for https://civicrm.stackexchange.com/questions/35323/missing-parameters-error-in-unsubscribe-confirmation The theory is that not having committed the transaction is causing the session not to be saved
eileenmcnaughton
force-pushed
the
session
branch
from
b2ca42a to
db93297
Compare
|
@pradpnayak I saw your SE comment - have you tested this? Just trying to figure out if it can hit the release window |
|
Just tested this and confirmed the mailing unsub page is submitted without any errors. Before -
After -
Thanks @eileenmcnaughton |
|
Merging as per review from @jitendrapurohit |
Merged
totten
changed the title
|
Note: I'm still seeing the error that this was supposed to fix, having applied the patch to 5.24.3. Not all the time, and annoyingly not when I test it! But seeing quite a few errors. of type described here: I've opened an issue here: |
|
@artfulrobot is it permission dependent? |
|
I've tested anonymously (using same link the person used for whom it crashed) - it works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix issue with form values not being available on submit
Possible fix for https://civicrm.stackexchange.com/questions/35323/missing-parameters-error-in-unsubscribe-confirmation
Before
Per https://civicrm.stackexchange.com/questions/35323/missing-parameters-error-in-unsubscribe-confirmation
After
Submit works
Technical Details
The theory is that not having committed the transaction is causing the session not to be saved
Comments