Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix handling of owner url parameter from Membership Dashboard #16937

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

This picks up a comment from @jitendrapurohit #16933 (comment) that the owner url parameter wasn't correctly being passed on for export and related purposes

Before

Owner URL param not respected in membership search export

After

Owner URL param respected

Technical Details

The member_is_primary field has not been added to the entity information yet and this is consistant with some other changes we have done for other url parameters e.g. https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/Form/Search.php#L126

ping @jitendrapurohit @eileenmcnaughton

@civibot
Copy link

civibot bot commented Apr 1, 2020

(Standard links)

@civibot civibot bot added the 5.24 label Apr 1, 2020
@eileenmcnaughton
Copy link
Contributor

I'm fine with this approach - happy to be conservative here & do a narrow fix

@eileenmcnaughton
Copy link
Contributor

Screen shot from demo site looks good
Screen Shot 2020-04-01 at 3 32 11 PM

@eileenmcnaughton eileenmcnaughton merged commit 1497c81 into civicrm:5.24 Apr 1, 2020
@eileenmcnaughton eileenmcnaughton deleted the 5.24 branch April 1, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants