Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv4 - Improve saveSearch popup in Explorer #16834

Merged
merged 1 commit into from
Mar 20, 2020
Merged

APIv4 - Improve saveSearch popup in Explorer #16834

merged 1 commit into from
Mar 20, 2020

Conversation

colemanw
Copy link
Member

Overview

Improves saving smart groups from the Api Explorer.

Before

image

After

image

Technical Details

  • UI adjusts to users' permission level for creating/administering groups
  • Existing group selector auto-opens
  • Styling fixed
  • Group type and visibility fields exposed

@civibot civibot bot added the master label Mar 18, 2020
@civibot
Copy link

civibot bot commented Mar 18, 2020

(Standard links)

@colemanw colemanw force-pushed the apiGroup branch 2 times, most recently from 75b1330 to 0a00ba1 Compare March 18, 2020 13:53
@colemanw colemanw changed the base branch from master to 5.24 March 20, 2020 12:47
@civibot civibot bot added 5.24 and removed master labels Mar 20, 2020
@colemanw
Copy link
Member Author

@eileenmcnaughton since this is polishing an unreleased feature I think it's better in the RC.

@eileenmcnaughton
Copy link
Contributor

I'm OK with that since it only affects the api v4 explorer

@eileenmcnaughton eileenmcnaughton merged commit db6701e into civicrm:5.24 Mar 20, 2020
@eileenmcnaughton eileenmcnaughton deleted the apiGroup branch March 20, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton