dev/core#547 Fix Event financial_type_id getOptions

[mlutfy]

Overview

RC for #16739

• https://dmaster.demo.civicrm.org/
• Disable the CiviPledge component, then disable the CiviContribute component
• Go to Events -> New Event
• Use the Paid Event template, fill in the title and start date
• Go to the Fee tab.

Result: fatal error.

Comments

This is a followup to #16365, which didn't fix the issue for me.

Seems odd to check if CiviEvent is enabled while in an Event BAO?

cc @mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

unrelated fail

[eileenmcnaughton]

@mlutfy I've merged this & am thinking about whether it should go in 5.23 too - I guess it should?

[mlutfy]

@eileenmcnaughton Hmm, re-reading dev/core#547, the issue may have existed for over a year? I don't think matt's PR caused a regression, it only fixed part of the bug.

[eileenmcnaughton]

ok cool