Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1366 - CRM_Case_XMLProcessor_Report::run() is never called anymore #16669

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

This function is no longer used. This is a further step towards removing unneeded case audit-related code.

Technical Details

To see that it's no longer used, start by grepping for CRM_Case_XMLProcessor_Report:

  • CRM_Case_BAO_Case: All it does is call getActivityInfo.
  • CRM_Case_Form_ActivityView: Ditto.
  • Inside itself: It doesn't call its own run() anywhere.
  • CRM/Case/xml/Menu/Case.xml: Points to a different function.

Then to understand why it's never used, it's because it was purposely bypassed in https://github.com/civicrm/civicrm-core/pull/15998/files#diff-fdb4ad333e7ba641428562199adc7dee. When you run the audit from manage case the options form you fill out no longer calls this when submitted.

Comments

There's more that can be removed but will be separate PRs.

@civibot civibot bot added the master label Mar 2, 2020
@civibot
Copy link

civibot bot commented Mar 2, 2020

(Standard links)

@colemanw colemanw merged commit 624faa8 into civicrm:master Mar 2, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks.

@demeritcowboy demeritcowboy deleted the audit-tpl-2 branch March 2, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants