dev/core#1605 State/province not copied on shared address

[alifrumin]

Overview

Ensure the state/province is copied when sharing an address.

More details including screenshots in the gitlab issue: https://lab.civicrm.org/dev/core/issues/1605

Before

1. User goes to a contact's summary tab
2. Clicks "Add Address"
3. Selects the "Use another contact's address" checkbox
4. Selects a contact with an address WITH a state
5. Clicks Save

Result: All the address fields are copied over EXCEPT the state/province.

After

When sharing an address the state province field IS copied

To Replicate:

1. User goes to a contact's summary tab
2. Clicks "Add Address"
3. Selects the "Use another contact's address" checkbox
4. Selects a contact with an address WITH a state
5. Clicks Save

Result: All the address fields are copied over INCLUDING the state/province.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[alifrumin]

Jenkins re test this please

[alifrumin]

Jenkins re test this please

[eileenmcnaughton]

I was just tormenting myself over whether we could get away with this without a test & then I scrolled down & lo-and-behold...

[eileenmcnaughton]

OK - I was able to replicate & see this fix - I did have some weird experiences doing it but they were in the formRule which is untouched so I think unrelated