Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Test cleanup. #16581

Merged
merged 1 commit into from
Feb 18, 2020
Merged

[NFC] Test cleanup. #16581

merged 1 commit into from
Feb 18, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Cleaned up this test - re-used code etc

Before

more code, harder to read

After

Less code, does the same thing

Technical Details

Comments

@civibot
Copy link

civibot bot commented Feb 18, 2020

(Standard links)

@civibot civibot bot added the master label Feb 18, 2020
@eileenmcnaughton
[NFC] Test cleanup.
b31fd59 
Cleaned up this test - re-used code etc
@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton
Copy link
Contributor Author

test this please

@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, merging this

@yashodha yashodha merged commit ba855f4 into civicrm:master Feb 18, 2020
@eileenmcnaughton eileenmcnaughton deleted the nfc branch February 18, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @yashodha