Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move determination of year & month to formatCreditCardDetails #16562

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Move determination of year & month to formatCreditCardDetails #16562

merged 1 commit into from
Feb 20, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code re-org Per #16514 it makes sense as a better place for these

Before

allocation of year & month are in a code chunk that concerns itself with assignments

After

allocation of year & month are in a code chunk that concerns itself with building params

Technical Details

Comments

@civibot
Copy link

civibot bot commented Feb 17, 2020

(Standard links)

@civibot civibot bot added the master label Feb 17, 2020
@eileenmcnaughton eileenmcnaughton mentioned this pull request Feb 17, 2020
Merged
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

This looks fine to me I think @mattwire ?

@mattwire mattwire merged commit 71ee7bf into civicrm:master Feb 20, 2020
@eileenmcnaughton eileenmcnaughton deleted the notice branch February 23, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @mattwire