dev/core#1592 fix regression on relation active period #16535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
523rel
branch
from
f65b5de to
0510f55
Compare
Per https://lab.civicrm.org/dev/core/issues/1592 the custom query for this field is being ignored now it's using datepicker with relevant format changes. This causes the custom function for the field to be called
eileenmcnaughton
force-pushed
the
523rel
branch
from
0510f55 to
c47a236
Compare
|
Tested this and confirmed that it fixes the issue in the ticket |
|
Test fail unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per https://lab.civicrm.org/dev/core/issues/1592 the custom query for this field is being
ignored now it's using datepicker with relevant format changes. This causes the
custom function for the field to be called
Before
Searching for relationships with an active period of 'Today' does not return results
After
Results returned (if relationships are active today)
Technical Details
This points the relativeDateQuery off to the field's special handling. It might be we have something else for 'is active' queries but this is enough for a regression fix. Note I had to extract the qill code to be shared with this FN
Comments