Throwing API_Exception is file fails to copy when creating attachment…

[albionbrown]

Overview

When creating an attachment using APIv3, the civicrm_api3_attachment_create function copies the file to the custom file upload directory. However, there is no error checking currently.

Before

The file would attempt to be copied and the original removed.
copy($moveFile, $path); unlink($moveFile);

If the directory is non-writable, the file would be lost.

After

if (!copy($moveFile, $path)) { throw new API_Exception("Cannot copy uploaded file ".$moveFile." to ".$path); } unlink($moveFile);

Now, an API_Exception is thrown before the file is removed.

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Add to whitelist

[albionbrown]

Would you prefer if I corrected those spaces and created another PR?

[colemanw]

@albionbrown well you definitely don't need to delete your fork :)
Don't actually need to delete this branch or PR either. You can just amend your commit.
Here's how I do minor touch-ups to existing commits in a PR:

git checkout #1565-API-Exception
(in your text editor, make the changes and save the file)
git commit -a --amend
git push -f origin #1565-API-Exception

[eileenmcnaughton]

Makes sense now the commits are cleaned