Settings Fix setting readonly attribute

[mattwire]

Overview

When the value of a mandatory setting (ie. defined via civicrm.settings.php) is 0 - eg. for empoweredBy and other radio elements the check incorrectly sets them as not readonly.

Before

Attribute readonly not set on input elements that have a mandatory value of 0.

After

Attribute readonly set correctly.

Technical Details

The if needs to explicitly check for NULL. Note that for radio input elements setting attribute readonly is not enough for them to actually be readonly... But this adds the attribute indicating that they should be readonly and you can then do something like:

$(document).ready(function() {
  CRM.$('input[readonly]').attr('disabled', true);
});

(I'm currently doing this in https://lab.civicrm.org/extensions/haystacktheme).

Comments

You'll need to use the browser console to inspect the element and see that it has readonly="1" set after this PR if you've defined it in civicrm.settings.php. Eg.
$civicrm_setting['core']['empoweredBy'] = 0;

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[colemanw]

re retest this please

[yashodha]

@mattwire Does this take care of Authentication? for SMTP Configuration as well?

[mattwire]

@yashodha I tried doing $civicrm_setting['mailing']['mailing_backend']['outBound_option'] = 2; but it didn't seem to make it through to Civi. So there might be another issue or I might not be specifying it properly in the civicrm.settings.php. But if the setting is picked up by Civi then it should get flagged as readonly on the form.

[mattwire]

@yashodha So this doesn't work with settings that are serialised before being stored in the DB but it didn't before. It does fix radio elements that are saved directly. Is this ok to merge? Then we could look at improving the other cases.

[eileenmcnaughton]

I think this makes sense to merge - it's form level & is logical. The only issue seems to be that non-standard settings don't benefit from it - a bridge for another day