dev/core#1217 Fix for failure to respect event_id (or any?) criteria … #16318
Conversation
…in smart groups From what I can tell it's possible to create smart groups from Advanced search & other contact searchs & Membership Search & Event search. Membership search actually just leverages advanced search but Event Search smart group has it's own code & reloads into Event search. This has been flawed for months but the current iteration is the criteria are not respected. On digging I found the decision was made in contact search to store the parsed QueryParams (in [field_name, 'IN', [1,2]] format not the formValues. I think this was probably a mistake. However, by adjusting the event code to do the same & ensuring the defaults are set it starts working again
|
(Standard links)
|
|
@eileenmcnaughton in the formValues that were stored for my busted smart group attempt it stored as |
|
@seamuslee001 well - the other regressed 4 months ago I think? So better to fix but if we don't get to it then at least sorting this is worth doing |
|
oh - not in the query object though - I'd fix the group in the DB & just handle one thing |
|
@eileenmcnaughton do you think we should merge this even if we don't fix the smart groups in the DB or do we have to do both? |
|
@seamuslee001 this is worth doing without the other because is means new ones can be created. Both is better but it's a 4 month old regression or even a never-worked so less urgent |
|
@seamuslee001 note that advanced search works for event smart groups & probably most people use that hence this has not been burning down the house |
|
yeh merging just figured need the question answer documented about reasoning |
|
It may never have worked |
Port of #16313
Note it didn't apply completely cleanup - I had to tweak. I have not tested on 5.21 at this stage