fix created_date/modified_date relative date filter searches

[MegaphoneJon]

Overview

There are two problems when using relative date filters that don't define both a begin and end date. E.g. "To end of previous year" or "From start of current week", as opposed to those that define a begin AND end date - e.g. "This month".

Before

SQL would be generated incorrectly, resulting in a syntax error.
After fixing this, I also noticed that there was a copy/paste error - when a start date but no end date is defined, the end date (always NULL) is used as the start date.

After

No syntax error in SQL.

Technical Details

The if statement that has the comment Special handling for contact table as it has a known alias in advanced search. was previously only invoked when both start and end dates are defined. I pulled it out to run a bit sooner, and also to run on the $secondWhere variable.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc)
  • (r-run) Pass I was able to replicate the issue and confirmed that this fixed. I also tested the Event Active On date which is where the second where would likely come into things and confirmed that still works.
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass

[MegaphoneJon]

Since this was a 5.20 regression, and it can break in unexpected ways (if used in a smart group), I think this makes sense for 5.21. Happy to submit a PR, also fine if that's not how it works, it's in my patch set regardless.

[eileenmcnaughton]

@MegaphoneJon that would be appreciated