dev/core#1144 (NFC) Handle fact that MySQL 8 always returns the colum… #16182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n name as it is in the DB not as it is in the query
|
(Standard links)
|
|
also @JoeMurray @monishdeb |
|
I'm going to merge this based on @totten commenting in product-maintenance "yeah, the PR makes perfect sense" https://chat.civicrm.org/civicrm/pl/n4mfkibt5pd9tqabarxzzkojpy and that the tests have passed |
|
Lol - I agree that is a strong statement coming from @totten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n name as it is in the DB not as it is in the query
Overview
In MySQL 8 the query outputs TABLE_NAME as the selector rather than table_name as it does in 5.7 and earlier.
Before
Tests cannot run on MySQL 8
After
Tests run on MySQL 8
ping @totten @eileenmcnaughton